Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Daily, Weekly, and Monthly enum values to strings.xml #136

Open
yamin8000 opened this issue Dec 22, 2023 · 2 comments
Open

Extract Daily, Weekly, and Monthly enum values to strings.xml #136

yamin8000 opened this issue Dec 22, 2023 · 2 comments
Labels
Projects
Milestone

Comments

@yamin8000
Copy link
Contributor

yamin8000 commented Dec 22, 2023

Also for the Recurrence Dropdown, you're using its enum name instead of providing a translated text.
I fixed this problem in one of my apps by introducing an integer variable inside the enum which refers to the resource id of the string equal to the current enum value.

@yamin8000 yamin8000 changed the title hardcoded string/strings hardcoded strings Dec 22, 2023
@waseefakhtar
Copy link
Owner

Thanks for reporting this! Definitely something we should fix.

@waseefakhtar waseefakhtar added this to To do 🗒 in Dose App via automation Dec 22, 2023
@waseefakhtar waseefakhtar added this to the 1.3 milestone Dec 22, 2023
@waseefakhtar
Copy link
Owner

All the hardcoded strings are now extracted in #126 except for the Recurrence dropdown so we can rename this to be clear.

@waseefakhtar waseefakhtar changed the title hardcoded strings Extract Daily, Weekly, and Monthly enum values to strings.xml Dec 25, 2023
@waseefakhtar waseefakhtar added the good first issue Good for newcomers label Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Dose App
To do 🗒
Development

No branches or pull requests

2 participants