Problem: hard to test cooperative execution #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because it relies on a scheduler outside of our domain (JavaScript) Solution: allow to run a callback after the queue is exhausted This changes `single_threaded::run_cooperatively` type signature a bit, adding an extra parameter. The testing is still not perfect as we can't really ensure the callback was called, but if it *was*, then we can run the assertions. This can be alternatively done by something like `join_all` for all futures representing tasks scheduled and spawning another task to do something after they've been joined, but it seems at the time that adding this callback has lower impact / easier ergonomics (but, of course, it's less "pure" if you may)
yrashk
force-pushed
the
cooperative-and-then
branch
from
de93617
to
089ed60
Compare
yrashk
changed the title
|
Obsoleted by #16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because it relies on a scheduler outside of our domain
(JavaScript)
Solution: allow to run a callback after the queue is exhausted
This changes
single_threaded::run_cooperativelytype signature a bit,adding an extra parameter.
The testing is still not perfect as we can't really ensure the callback
was called, but if it was, then we can run the assertions.
This can be alternatively done by something like
join_allfor allfutures representing tasks scheduled and spawning another task to do
something after they've been joined, but it seems at the time that
adding this callback has lower impact / easier ergonomics (but, of
course, it's less "pure" if you may)