New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate manifests before accepting them #122
Comments
One possible solution here is to define a json schema and use that: https://docs.rs/jsonschema/latest/jsonschema/ |
Consider #123 and @autodidaddict's scenarios when validating the manifests |
One more comment, I think this issue should cover the problem outlined in #131 and reject non-string label requirements. |
Here are some of the cases covered in #153
The next PR will cover validation using a JSONSchema for manifest items. |
Right now we blindly accept manifests without any validation. This causes issues where you might have misplaced something like your spread definitions and also leads to manifests fighting with each other (if two different manifests link to the same provider with different values, so those scalers each try to compete to set their version of the linkdef). At the minimum, validation should probably include:
The text was updated successfully, but these errors were encountered: