Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a PutModelRequest type and change the put endpoint #74

Open
thomastaylor312 opened this issue Apr 4, 2023 · 5 comments
Open
Labels
roadmap Planned work

Comments

@thomastaylor312
Copy link
Contributor

After talking with @brooksmtownsend we think that a manifest should always deploy by default when it is put, but this means we need a request body to indicate when we don't want it to deploy immediately. So we'll need to modify the put endpoint to expect a different body

@thomastaylor312
Copy link
Contributor Author

Note: This should happen either after wadm 0.4 work is done or in wadm 0.5

@brooksmtownsend
Copy link
Member

I mostly think this would be nice from an initial perspective, consolidating the put/deploy action into one command which would make it easy for us. Perhaps we could have the deploy body take a manifest instead of a name as an alternative? e.g. wash app deploy -f echo.yaml

Trying to tie this closely to the way that kubectl apply works, which IMO is a great experience for starting out. Oneliner, idempotent, accepts a file or stdin, etc

@thomastaylor312
Copy link
Contributor Author

I think how we present it as a cli is different from how we structure it as an API. I'm not opposed to adding a shorthand like you suggest, but as an API it might make more sense to keep updating data and deploying said data different parts of the API.

@stale
Copy link

stale bot commented Jun 6, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this has been closed too eagerly, please feel free to tag a maintainer so we can keep working on the issue. Thank you for contributing to wasmCloud!

@stale stale bot added the stale label Jun 6, 2023
@thomastaylor312
Copy link
Contributor Author

Def not stale

@stale stale bot removed the stale label Jun 7, 2023
@brooksmtownsend brooksmtownsend added the roadmap Planned work label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
roadmap Planned work
Projects
None yet
Development

No branches or pull requests

2 participants