Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

[BUG] nix build test is flaky while building for MacOS #628

Closed
vados-cosmonic opened this issue Jun 22, 2023 · 2 comments
Closed

[BUG] nix build test is flaky while building for MacOS #628

vados-cosmonic opened this issue Jun 22, 2023 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@vados-cosmonic
Copy link
Contributor

vados-cosmonic commented Jun 22, 2023

Describe the bug
Periodically, when running the nix build for MacOS it fails (throwing the 137 for OOMKill, then 9 for SIGKILL):

copying path '/nix/store/vf9irc1alx9xvddff63asdrlhv1imm6g-gmp-with-cxx-6.2.1' from 'https://cache.nixos.org/'...
copying path '/nix/store/2n2i79dlpv559mwy7my7jf41agm6rf1s-coreutils-9.3' from 'https://cache.nixos.org/'...
/Users/runner/work/_temp/32bf7a0b-acce-4894-ba81-c3b380b56c34.sh: line 1: 30825 Killed: 9               nix run -L --inputs-from . 'nixpkgs#coreutils' -- --coreutils-prog=ginstall -p "./result/bin/wash" 'wash-x86_64-apple-darwin'
Error: Process completed with exit code 137.

The problem seems to be the use of the GNU install provided by nixpkgs#coreutils in action.yml (the assumption here being that there is too much memory used by installing the coreutils install).

A possible solution is to replace that with platform specific solutions for installing the binary.

There don't seem to be many other solutions for nix memory usage discussed online other than enabling swap, but there is also the option of using a MacOS XL runner

Once this is finished, continue-on-error should be removed from .github/workflows/nix.yml

To Reproduce
Steps to reproduce the behavior:

  1. Run the wash-x86_64-apple-darwin CI build
  2. Observe an unexplained failure (signal 137 -> signal 9)
  3. See error

Expected behavior

The build should pass consistently

Screenshots
If applicable, add screenshots to help explain your problem.

**Environment (please complete the following information) **

  • OS: MacOS
  • Shell: zsh
  • wash Version next

Additional context
Add any other context about the problem here.

@vados-cosmonic vados-cosmonic added bug Something isn't working help wanted Extra attention is needed labels Jun 22, 2023
@vados-cosmonic
Copy link
Contributor Author

This has a chance of being solved by using a larger runner

@vados-cosmonic
Copy link
Contributor Author

This was resolved by #619

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
No open projects
Archived in project
Development

No branches or pull requests

1 participant