Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] OTEL over NATS #1040

Closed
hwinkel opened this issue Nov 19, 2023 · 6 comments
Closed

[FEATURE] OTEL over NATS #1040

hwinkel opened this issue Nov 19, 2023 · 6 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@hwinkel
Copy link

hwinkel commented Nov 19, 2023

OTEL Traces and Metrics over NATS

Can the NATS Connectivity used to encapsulate the transport of the OTEL trace and later metrics data?
It would be good to use the NATS lattice to forward the telemetry data regardless of the topology and
not rely on 1:1 HTTP connections.

@hwinkel hwinkel added enhancement New feature or request help wanted Extra attention is needed labels Nov 19, 2023
@thomastaylor312
Copy link
Contributor

Hi @hwinkel! So for many of the things inside of the wasmcloud host we use this crate to put the otel data in the NATS headers. However, we were planning on removing it from everything except for the NATS provider as we use a field in our Invocation type to send the trace data. Can you give me a little more info on your use case? If there are some good reasons why we shouldn't remove it, it would be great to know!

Copy link

stale bot commented Jan 19, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this has been closed too eagerly, please feel free to tag a maintainer so we can keep working on the issue. Thank you for contributing to wasmCloud!

@stale stale bot added the stale label Jan 19, 2024
@thomastaylor312
Copy link
Contributor

So we will likely be adding support back for otel NATS headers via our forthcoming wRPC work in #1128

@stale stale bot removed the stale label Jan 24, 2024
Copy link

stale bot commented Mar 24, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this has been closed too eagerly, please feel free to tag a maintainer so we can keep working on the issue. Thank you for contributing to wasmCloud!

@stale stale bot added the stale label Mar 24, 2024
@thomastaylor312
Copy link
Contributor

@brooksmtownsend We can mark this as closed now, right?

@stale stale bot removed the stale label Mar 25, 2024
@brooksmtownsend
Copy link
Member

Yes! We did this, logging support is in v0.82 and metrics supports comes with 1.0 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants