feat: rework the operator for wasmCloud 1.0 compatibility #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF ScorecardScorecard details
Scanned Manifest FilesCargo.lock
|
protochron
force-pushed
the
1.0_compat
branch
3 times, most recently
from
71347df
to
790334d
Compare
joonas
reviewed
Apr 10, 2024
joonas
reviewed
Apr 10, 2024
joonas
reviewed
Apr 10, 2024
joonas
reviewed
Apr 10, 2024
src/services.rs
Outdated
| should_create_service = true; | ||
| for p in props.source_config.iter() { | ||
| if let Some(config_props) = &p.properties { | ||
| if let Some(addr) = config_props.get("ADDRESS") { |
There was a problem hiding this comment.
I'm curious why is the ADDRESS capitalized here? Looking at the provider code it didn't seem like that defines it as capitalized, but all lowercase, am I missing some conversion logic that happens in between?
There was a problem hiding this comment.
For whatever reason the wadm file I was working off of was in all caps and I wasn't sure why. I'll fix it so that is uses the correct case as outlined in the provider docs.
protochron
force-pushed
the
1.0_compat
branch
2 times, most recently
from
764e881
to
d23227f
Compare
joonas
approved these changes
Apr 10, 2024
wasmCloud 1.0 fully converts over to using components among other large changes, so we need to rework the operator to account for it. 1.0 is still in the works, so this updates the operator to depend on wasmCloud 1.0 libraries along with refactoring the service creation code to use the updated application manifest format. Once this is in we will likely cut a 0.2.0 pre-release and wait for an actual release until wasmCloud 1.0.0 and wadm 0.11 are out. This also adds a new field to the CRD so that you can specify the full image reference instead of just the version. The `image` parameter takes precedence. Signed-off-by: Dan Norris <protochron@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
wasmCloud 1.0 fully converts over to using components among other large changes, so we need to rework the operator to account for it. 1.0 is still in the works, so this updates the operator to depend on wasmCloud 1.0 libraries along with refactoring the service creation code to use the updated application manifest format.
Once this is in we will likely cut a 0.2.0 pre-release and wait for an actual release until wasmCloud 1.0.0 and wadm 0.11 are out.
This also adds a new field to the CRD so that you can specify the full image reference instead of just the version. The
imageparameter takes precedence.Related Issues
Release Information
0.2.0
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification