feat: enable additional scheduling options for wasmCloud host pods #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
protochron
force-pushed
the
node_affinity
branch
from
fbb9e6c
to
5677301
Compare
joonas
reviewed
Apr 1, 2024
joonas
approved these changes
Apr 1, 2024
thomastaylor312
requested changes
Apr 1, 2024
There was a problem hiding this comment.
All nits, but we do need the fix in the example that @joonas called out
This refactors the WasmCloudHostConfig CRD so that it has a single field (`schedulingOptions`) for configuring how the underlying Pods are scheduled in Kubernetes. This includes: * Relocating the `daemonset` option to this new field * Relocating the `resources` option to this new field * Adding a new `pod_template_additions` field that allows you to set any valid option in a `PodSpec` Doing so allows cluster operators to do things like set node affinity and node selector rules, along with any other valid PodSpec option. The only thing that cannot be done is adding additional containers to the pod, since that is all handled by the controller. We could look at exposing that option if users want to be able to add additional sidecars. Signed-off-by: Dan Norris <protochron@users.noreply.github.com>
protochron
force-pushed
the
node_affinity
branch
from
5677301
to
e671b4f
Compare
|
@thomastaylor312 all fixed. PTAL |
thomastaylor312
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This refactors the WasmCloudHostConfig CRD so that it has a single field (
schedulingOptions) for configuring how the underlying Pods are scheduled in Kubernetes. This includes:daemonsetoption to this new fieldresourcesoption to this new fieldpod_template_additionsfield that allows you to set any valid option in aPodSpecDoing so allows cluster operators to do things like set node affinity and node selector rules, along with any other valid PodSpec option. The only thing that cannot be done is adding additional containers to the pod, since that is all handled by the controller. We could look at exposing that option if users want to be able to add additional sidecars.
Related Issues
Release Information
next
Consumer Impact
Testing
Tested locally in kind by setting
daemonset: trueand adding a node selector, both of which correctly changed the configuration of the underlying pods.Unit Test(s)
Acceptance or Integration
Manual Verification