Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid values? #20

Open
dfaust opened this issue Jul 24, 2023 · 0 comments
Open

Invalid values? #20

dfaust opened this issue Jul 24, 2023 · 0 comments

Comments

@dfaust
Copy link

dfaust commented Jul 24, 2023

Hi. I'm sorry for being a bit negative. But don't think the values calculated by this crate are correct. Either that or I didn't understand what this crate tries to achieve.

For example the following screen shot shows the tests for the Option type. I expected the size of the Option to always be the same, whether it contains a value, or not. Also the values for the padding seem off.

grafik

For collections only the length is counted. I expected it to be the entire capacity.

grafik

For reference, I think https://github.com/DKerp/get-size gets it right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant