Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor WASI globals logic #3840

Open
syrusakbary opened this issue May 3, 2023 · 3 comments
Open

Refactor WASI globals logic #3840

syrusakbary opened this issue May 3, 2023 · 3 comments
Assignees
@syrusakbary @Arshia001
Labels
priority-high High priority issue
Milestone
v4.4

Comments

@syrusakbary
Copy link
Member

As of the release of Wasmer 3.3 with JavascriptCore there are some issues with WASIX (related to globals).

That's ok for now since they are only caused when using special systemcalls that are not part of wasi. But it will be not ok when we release WASIX.
We need to move the globals logic from the store to the wasi crate, as a way to simplify the codebase and fix the issues
@syrusakbary syrusakbary changed the title Refactor WASIX globals logic Refactor WASI globals logic May 3, 2023
@ptitSeb ptitSeb added the priority-high High priority issue label May 3, 2023
@ptitSeb ptitSeb added this to the v4.0 milestone May 3, 2023
@syrusakbary
Copy link
Member Author

Related: #3602

@theduke
Copy link
Contributor

theduke commented May 9, 2023

Will need to re-write the WASM to export all globals so we can read them in the browser.

@ptitSeb
Copy link
Contributor

ptitSeb commented May 30, 2023

Stretch goal.

@ptitSeb ptitSeb modified the milestones: v4.0, v4.1 Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@syrusakbary syrusakbary

@Arshia001 Arshia001

Labels
priority-high High priority issue
Projects
None yet
Milestone
v4.4
Development

No branches or pull requests
4 participants
@syrusakbary @theduke @ptitSeb @Arshia001