Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation of cfg_attr(..., crate_type = "...") #4468

Open
est31 opened this issue Feb 27, 2024 · 2 comments
Open

Deprecation of cfg_attr(..., crate_type = "...") #4468

est31 opened this issue Feb 27, 2024 · 2 comments
Assignees
Labels
📦 lib-api About wasmer priority-medium Medium priority issue

Comments

@est31
Copy link

est31 commented Feb 27, 2024

Hi,

I'm filing this issue to point out that declaring crate_type inside a cfg_attr is deprecated and will error at a certain point in the future. wasmer uses this construct in lib.rs:

#![cfg_attr(feature = "js", crate_type = "cdylib")]

I would have liked to open a PR to fix the usage but I don't fully understand where everywhere the run instructions are, so instead I opened this issue to discuss approaches to move away from cfg_attr. Thanks!

See also: rust-lang/rust#91632

Copy link

linear bot commented Feb 27, 2024

@est31
Copy link
Author

est31 commented Feb 27, 2024

There is two suggested workarounds in rust-lang/rust#91632 (comment) and rust-lang/rust#91632 (comment)

@Arshia001 Arshia001 added 📦 lib-api About wasmer priority-medium Medium priority issue labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 lib-api About wasmer priority-medium Medium priority issue
Projects
None yet
Development

No branches or pull requests

3 participants