Mount current directory to /home and Set CWD to /home when running WASI
#4730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: this would be a (small) breaking behaviour change. It shouldn't have a big effect, but it might break users that rely on the path in some logic. Are we okay with that? |
syrusakbary
reviewed
May 22, 2024
syrusakbary
reviewed
May 22, 2024
syrusakbary
reviewed
May 31, 2024
There was a problem hiding this comment.
Hey, I saw that we went into a different framework for testing that wasix-fyi, and I think this has some tradeoffs.
That means, that we should have two steps:
- Build (https://github.com/wasmerio/wasmer/blob/main/tests/wasi-fyi/build.sh)
- Test (in the similar fashion that wasi-fyi, https://github.com/wasmerio/wasmer/blob/main/tests/wasi-fyi/wasm-test.sh) -> Please see how the mapped dirs (via
$input_base.dir), args and so on are provided in a framework-like fashion). We should use the same strategy here
syrusakbary
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4725
Resolves #4724
Resolves #4753