Always flush when writing, even if we get invalid pointers #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syrusakbary
approved these changes
Aug 28, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 28, 2019
731: Always flush when writing, even if we get invalid pointers r=MarkMcCaskey a=MarkMcCaskey Not exactly an "invalid pointer" but, we were seeing an iovec of length 0 passed in which was causing `__WASI_EFAULT` which was preventing things from flushing properly. While I was fixing this, I decided to clean it up and make the behavior more obvious by creating a wrapper function. Co-authored-by: Mark McCaskey <mark@wasmer.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not exactly an "invalid pointer" but, we were seeing an iovec of length 0 passed in which was causing
__WASI_EFAULTwhich was preventing things from flushing properly.While I was fixing this, I decided to clean it up and make the behavior more obvious by creating a wrapper function.