Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reliably emit backtraces #4

Closed
dhil opened this issue Sep 6, 2023 · 3 comments
Closed

Reliably emit backtraces #4

dhil opened this issue Sep 6, 2023 · 3 comments
Assignees
@frank-emrich
Labels
bug Something isn't working enhancement New feature or request

Comments

@dhil
Copy link
Member

dhil commented Sep 6, 2023

Sometimes the printing of backtraces fail due to a false assertion. For example, https://github.com/wasmfx/wasmfxtime/blob/main/crates/runtime/src/traphandlers/backtrace.rs#L214 (there is one more by the end of the file). These kind of assertions are not always true in the presence of the WasmFX instruction set.

It probably suffices to remove the assertions.
@dhil
Copy link
Member Author

dhil commented Nov 3, 2023

A crude fix was introduced by PR #35.

@dhil dhil added bug Something isn't working enhancement New feature or request labels Nov 3, 2023
@dhil
Copy link
Member Author

dhil commented Nov 3, 2023

PR #42 further expands on the crude fix introduced by #35.

@dhil
Copy link
Member Author

dhil commented May 14, 2024

Fixed in a previous PR by @frank-emrich.

@dhil dhil closed this as completed May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frank-emrich frank-emrich

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dhil @frank-emrich