Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wasmi::Linker::func_wrap method #663

Closed
Robbepop opened this issue Feb 10, 2023 · 3 comments · Fixed by #692
Closed

Add wasmi::Linker::func_wrap method #663

Robbepop opened this issue Feb 10, 2023 · 3 comments · Fixed by #692
Labels
wasmtime-mirror Issue for a use case of a missing API that exists in Wasmtime.

Comments

@Robbepop
Copy link
Member

Robbepop commented Feb 10, 2023

This allows to define host functions for a Linker without the need to associate them to a Store and enable cross-store sharing of those host functions.

This feature request came up first in #657 (comment). Note the explanation of Linker::define confusion: #657 (comment)

cc @flavio

@Robbepop Robbepop added the wasmtime-mirror Issue for a use case of a missing API that exists in Wasmtime. label Feb 10, 2023
@flavio
Copy link

flavio commented Feb 22, 2023

I looked into the WIP code I had, there's still a lot to be done and I doubt I would be able to get this done quickly. Hence, you can work on this issue @Robbepop.

Once this API is released I'll update my wit-bindgen fork to make use of it.

Thanks!

@Robbepop
Copy link
Member Author

Okay, will work on it soon(TM).

Looking forward to the wit-bindgen update! :)
Any chance your work on wit-bindgen might be merged into mainline?

@flavio
Copy link

flavio commented Feb 22, 2023

Okay, will work on it soon(TM).

Thanks, no hurries!

Any chance your work on wit-bindgen might be merged into mainline?

I doubt, from my understanding they want to split the current implementation into modular blocks that would allow everybody to write their own wit-bindgent. I think the end goal could be to have my code into a dedicated repository, which would no longer be a fork.

However, thinks are moving really fast and everything keeps breaking in between each iteration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasmtime-mirror Issue for a use case of a missing API that exists in Wasmtime.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants