Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Wasmi bytecode (pretty-)printing #977

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Implement Wasmi bytecode (pretty-)printing #977

wants to merge 1 commit into from

Conversation

Robbepop
Copy link
Collaborator

@Robbepop Robbepop commented Apr 8, 2024 •
edited

Closes #972.

TODO

  • trap
  • fuel.consume
  • return instructions
  • return.nez instructions
  • return.call instructions
  • branch instructions
  • branch.table
  • branch.cmp instructions
  • copy instructions
  • call instructions
  • select instructions
  • global instructions
  • load instructions
  • store instructions
  • cmp instructions
  • i32 and i64 unary instructions
  • f32 and f64 unary instructions
  • i32 and i64 binary instructions
  • f32 and f64 binary instructions
  • conversion instructions
  • memory bulk instructions
  • table bulk instructions

@codecov Codecov
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 1056 lines in your changes are missing coverage. Please review.

Project coverage is 78.41%. Comparing base (da34467) to head (baed668).

Files Patch % Lines
crates/wasmi/src/engine/bytecode/print.rs 0.00% 1049 Missing ⚠️
crates/wasmi/src/engine/bytecode/utils.rs 0.00% 7 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #977      +/-   ##
==========================================
- Coverage   81.87%   78.41%   -3.47%     
==========================================
  Files         260      261       +1     
  Lines       23904    24960    +1056     
==========================================
  Hits        19572    19572              
- Misses       4332     5388    +1056

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make it possible to debug and pretty print Wasmi bytecode
1 participant
@Robbepop