Translator for start function (remapstart)

[axic]

1. Rename the function pointed to by the start section to main. If there is another function named main, rename it (prefix it with _) to avoid conflict – if there this conflicts with another function, keep adding underscore prefixes until it won't.

2. Remove the start section. (See dropstartfunction.)

[jwasinger]

Gonna take this one on

[jwasinger]

(See dropstartfunction.)

What do you mean by this? Referring to the pwasm API I am guessing.

[axic]

(See dropstartfunction.)

What do you mean by this? Referring to the pwasm API I am guessing.

https://github.com/wasmx/wasm-chisel/blob/master/libchisel/src/trimstartfunc.rs

[jakelang]

@axic I see no real reason to drop the names section, as export names are unique. The names section exists solely as a custom section to aid debuggers and other binary tools.

[axic]

The reason is that we were lazy to check if the exported names are duplicated in the names section.

[jakelang]

They aren't, and the names section doesn't seem to matter anyway. Maybe introducing another module for that later would make more sense (as opposed to implicit behavior in remapstart).

[axic]

We have another which removes sections. It does matter because we don't want to generate an invalid output.

This is the spec: https://webassembly.github.io/spec/core/appendix/custom.html#name-section

[axic]

Agreed that other transformations changing the export section don't deal with the names section. We should clarify this and fix if needed, but we can do it after remapstart.