Module source pinned ref check #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
wata727
reviewed
Apr 15, 2017
detector/detector.go
Outdated
| } | ||
| // Special case for module_pinned_source rule | ||
| modulePinnedSourceRule := "module_pinned_source" | ||
| if d.Config.IgnoreModule[modulePinnedSourceRule] { |
detector/detector.go
Outdated
| continue | ||
| } | ||
| // Special case for module_pinned_source rule | ||
| modulePinnedSourceRule := "module_pinned_source" |
There was a problem hiding this comment.
Please rename to terraform_module_pinned_source :)
wata727
reviewed
Apr 17, 2017
| } | ||
| d.Logger.Info(fmt.Sprintf("run module linter `%s`", name)) | ||
| modulePinnedSourceDetector := NewTerraformModulePinnedSourceDetector(d, m.File, m.ObjectItem) |
There was a problem hiding this comment.
[gometalinter]
- [interfacer] undeclared name: NewTerraformModulePinnedSourceDetector
- [structcheck] unused struct field undeclared name: NewTerraformModulePinnedSourceDetector
- [unconvert] undeclared name: NewTerraformModulePinnedSourceDetector
- [staticcheck] undeclared name: NewTerraformModulePinnedSourceDetector
- [gosimple] undeclared name: NewTerraformModulePinnedSourceDetector
- [varcheck] unused variable or constant undeclared name: NewTerraformModulePinnedSourceDetector
OmarDarwish
force-pushed
the
module-source-ref-check
branch
from
d02853b
to
e3cc826
Compare
wata727
reviewed
Apr 18, 2017
docs/README.md
Outdated
| @@ -28,6 +28,8 @@ Issues are classified into the following three types. | |||
| - **AWS Route** | |||
| - [aws_route_not_specified_target](aws_route_not_specified_target.md) | |||
| - [aws_route_specified_multiple_targets](aws_route_specified_multiple_targets.md) | |||
| - **Terraform** | |||
| - [module_pinned_source](module_pinned_source.md) | |||
There was a problem hiding this comment.
Please also rename this link and title.
|
@OmarDarwish Great work! I'm very pleased to add such a useful detector! |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to add a warning to modules from source control that either do not pin a version or pin to a default version. Documentation is provided here