Provide abstract HCL access #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wata727
commented
May 28, 2017
schema/schema.go
Outdated
| Resources: []*Resource{}, | ||
| } | ||
| var ret map[string]map[string]interface{} | ||
| root, _ := parser.Parse(body) |
There was a problem hiding this comment.
[gometalinter]
- [gas] Errors unhandled.,LOW,HIGH
wata727
commented
May 28, 2017
schema/schema.go
Outdated
| } | ||
| var ret map[string]map[string]interface{} | ||
| root, _ := parser.Parse(body) | ||
| hcl.DecodeObject(&ret, root) |
There was a problem hiding this comment.
[gometalinter]
- [gas] Errors unhandled.,LOW,HIGH
wata727
commented
May 28, 2017
| } | ||
|
|
||
| for _, template := range templates { | ||
| sort.Slice(template.Resources, func(i, j int) bool { |
There was a problem hiding this comment.
[gometalinter]
- [gosimple] Slice not declared by package sort
- [staticcheck] Slice not declared by package sort
- [varcheck] unused variable or constant Slice not declared by package sort
There was a problem hiding this comment.
Hmm... sort.Slice is valid function 🤔
wata727
commented
Jun 13, 2017
| } | ||
| } | ||
|
|
||
| func appendTemplates(templates []*Template, files map[string][]byte, override bool) ([]*Template, error) { |
There was a problem hiding this comment.
[gometalinter]
- [gocyclo] cyclomatic complexity 16 of function appendTemplates() is high (> 15)
wata727
commented
Jun 13, 2017
| } | ||
|
|
||
| for _, template := range templates { | ||
| sort.Slice(template.Resources, func(i, j int) bool { |
There was a problem hiding this comment.
[gometalinter]
- [staticcheck] Slice not declared by package sort
- [gosimple] Slice not declared by package sort
- [varcheck] unused variable or constant Slice not declared by package sort
wata727
commented
Jun 13, 2017
| fmt.Fprintln(cli.errStream, fmt.Errorf("ERROR: Parse error: %s", err)) | ||
| return ExitCodeError | ||
| } | ||
| cli.detector, err = detector.NewDetector(templates, schema, state, tfvars, c) |
There was a problem hiding this comment.
[gometalinter]
- [ineffassign] ineffectual assignment to err
wata727
commented
Jun 17, 2017
| } | ||
| } | ||
|
|
||
| func appendTemplates(templates []*Template, files map[string][]byte, override bool) ([]*Template, error) { |
There was a problem hiding this comment.
[gometalinter]
- [gocyclo] cyclomatic complexity 17 of function appendTemplates() is high (> 15)
wata727
commented
Jun 17, 2017
| } | ||
|
|
||
| for _, template := range templates { | ||
| sort.Slice(template.Resources, func(i, j int) bool { |
There was a problem hiding this comment.
[gometalinter]
- [varcheck] unused variable or constant Slice not declared by package sort
- [gosimple] Slice not declared by package sort
- [staticcheck] Slice not declared by package sort
wata727
commented
Jun 18, 2017
| fmt.Fprintln(cli.errStream, fmt.Errorf("ERROR: Parse error: %s", err)) | ||
| return ExitCodeError | ||
| } | ||
| cli.detector, err = detector.NewDetector(templates, schema, state, tfvars, c) |
There was a problem hiding this comment.
[gometalinter]
- [ineffassign] ineffectual assignment to err
- [staticcheck] this value of err is never used (SA4006)
wata727
commented
Jun 18, 2017
| } | ||
|
|
||
| for _, template := range templates { | ||
| sort.Slice(template.Resources, func(i, j int) bool { |
There was a problem hiding this comment.
[gometalinter]
- [gosimple] Slice not declared by package sort
- [staticcheck] Slice not declared by package sort
- [varcheck] unused variable or constant Slice not declared by package sort
wata727
changed the title
wata727
force-pushed
the
abstract_hcl_access
branch
from
1b08c3f
to
1b4bece
Compare
wata727
commented
Jun 18, 2017
| } | ||
|
|
||
| for _, template := range templates { | ||
| sort.Slice(template.Resources, func(i, j int) bool { |
There was a problem hiding this comment.
[gometalinter]
- [staticcheck] Slice not declared by package sort
- [varcheck] unused variable or constant Slice not declared by package sort
- [gosimple] Slice not declared by package sort
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #103
Currently, TFLint takes a direct reference to the interface provided by hashicorp/hcl. But, In this approach, handling of override is very difficult.
As a countermeasure for this problem, introduce
schemapackage. In this approach, all access to HCL is through this package. So, override implementation is in this package.