Add AwsECSClusterDuplicateNameDetector #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wata727
commented
Jul 22, 2017
| awsClient := c.NewAwsClient() | ||
| ctrl := gomock.NewController(t) | ||
| defer ctrl.Finish() | ||
| ecsmock := mock.NewMockECSAPI(ctrl) |
There was a problem hiding this comment.
[gometalinter]
- [staticcheck] NewMockECSAPI not declared by package mock
- [gosimple] NewMockECSAPI not declared by package mock
- [varcheck] unused variable or constant NewMockECSAPI not declared by package mock
wata727
force-pushed
the
aws_ecs_cluster_duplicate_name
branch
from
b57eb9e
to
92716f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This detector detects duplicate ECS cluster name (cluster name must be unique).