Use cristim/ec2-instances-info instead of hard-coded list
#159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wata727
force-pushed
the
add_instance_type
branch
from
aaeb6ad
to
ce39d80
Compare
cristim
suggested changes
Nov 12, 2017
There was a problem hiding this comment.
I maintain a library based on the data from ec2instances.info, which can be used instead of maintaining this hard-coded list, you can find it here https://github.com/cristim/ec2-instances-info
|
That's a good idea. I will try it :) |
wata727
changed the title
cristim/ec2-instances-info instead of hard-coded list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
db.r4.*family (for Aurora only)x1e.32xlarge,c5.*family andp3.*family