automate the installation of tflint on linux

[tchia04]

Hopefully, this will address issue#263

[wata727]

Thanks for opening the PR, but it does not seem to work correctly in my environment...

$  curl https://raw.githubusercontent.com/tchia04/tflint/install_linux/install_linux.sh | bash                                                                                          [0:25:15]
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1398  100  1398    0     0   8630      0 --:--:-- --:--:-- --:--:--  8683
os=darwin_amd64


====================================================
Looking up the latest version ...
Downloading latest version of tflint which is v0.7.4
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   613    0   613    0     0    990      0 --:--:-- --:--:-- --:--:--   990
100 10.6M  100 10.6M    0     0  2606k      0  0:00:04  0:00:04 --:--:-- 3603k
Download was successfully


====================================================
Unpacking and Installing tflint ...
Archive:  /tmp/tflint.zip
install: /tmp/tflint: Inappropriate file type or format

[tchia04]

When I tested this on another mac without /usr/local/bin directory, I got a "permission denied" error. So I added the "mkdir -p /usr/local/bin" to make sure the directory exist first. Also I have added sudo to the install command. Hopefully that will resolve your issue.

[wata727]

After deleting tmp/tflint*, I confirmed that it works well. However, I'm not sure if we should use sudo in such installation scripts. Do you have any other good ideas? Also, is it common for sudo to be used in such scripts?

[tchia04]

Yes installing to the /usr/local/bin folder usually requires root permission.
I chose this location because usually this folder is already in the PATH and doesn't require update the PATH in .bashrc or .bash_profile file

One solution to not use sudo is to copy the executable to ~/bin/ folder instead of /usr/local/bin/ but this may require setting up the PATH to include ~/bin which the script doesn't checks for

i.e. Need something like this in ~/.bash_profile
export PATH="$HOME/bin:$PATH"

[wata727]

Thanks!