Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terraform 0.12 adds support for dynamic nested blocks. At present, the
WalkResourceBlocks
API only extracts the structure on HCL and walks on it, so it cannot support such dynamic blocks.For complete support, we need to evaluate and expand the blocks like Terraform way.
ExpandBlock
andEvalBlock
are likely to be helpful. However, when evaluating a block, we must consider the possibility that the block contains unevaluable values such as unknown or unsupported references. Unfortunately, in that case, we must ignore all that block.In this PR, in order to avoid this problem, we walk the dynamic block partially as the HCL structure without evaluating the block. So we can't still evaluate expressions that contain iterators, but fortunately, the
aws_instance_default_standard_volume
rule doesn't require value evaluation.