Cast error in RegularLevel and Heap

[Lertsenem]

Hi !

First of all, thanks for releasing the source code of your amazing game !

Unfortunately, the code does not compile as is on my station (java 6). It fails with two similar casting errors, in Heap.java and RegularLevel.java. I looked it up, and the statement

(Collection<? extends Item>) bundle.getCollection(ITEM)

seems bogus to me: Item implements Bundlable, not the opposite. The error is very similar in RegularLevel.java.

I tried to fix it but I'm not a Java Guru, so feel free to reject my pull request and provide a better version of this fix. :]

[tehface]

you might want to update to java 7

[Lertsenem]

Well, you can make that pull request a "Compatibility backport for java 6" then.

[sylvia43]

Just get Java 7. Compatability can be really annoying at times.

[mvdan]

I tried building it with the following in ant.properties:

java.source=1.7
java.target=1.7
java.encoding=ISO-8859-1

Still getting the same error, although the encoding warnings are gone. @watabou, could you please upload your ant.properties or project.properties files so that we can use the setup that you use? Or do you build with maven, gradle or something else other than ant?

[mvdan]

Forgot to note: I'm using OpenJDK 1.7.0_65, which afaik is the latest version.

[sylvia43]

I can take a look at it, I'm pretty good with Java. What is bundle.getCollection(ITEM) returning?

[tehface]

compile with the android sdk bundle works perfect .... ant/maven will fail other wise

[mvdan]

@tehface you mean with an IDE? building with ant is standard, getting it to work should be very easy.

[Lertsenem]

compile with the android sdk bundle works perfect

Could you be more specific ? what steps are you taking to build with no error ? I didn't manage to do just that.

From what I understand, this looks like a mere casting error:

1. class Item implements Bundlable
2. bundle.getCollection() returns a Collection<Bundlable>
3. You want to get a Collection<Item> from your Collection<Bundlable>

A cast as Collection<? extends Item> won't cut it: Item extends (well, implements) Bundlable, not the other way around.

[Lertsenem]

This pull request has no reason to be anymore. Closing.