Notify user when scroll of upgrade removes weapon enchantment

[mchelen]

Edit: Please add a notification for the user when a scroll of upgrade removes a weapon enchantment.

I found a Vampiric mace, and when a Scroll of Upgrade was applied it lost its Vampiric enchantment. The weird thing is I'm pretty sure I had applied a few Scrolls of Upgrade already, but the last one I applied when it was +3 caused the enchantment to be lost.

[miohtama]

I think this is a feature, not a bug. (At least read about it in pixeldungeon.wikia.com/wiki/ )

[tousdan]

It is not a bug. It's actually a tip you see on a sign after DM-300.

See this file for the actual tip;

pixel-dungeon/src/com/watabou/pixeldungeon/Dungeon.java

Line 96 in 3ce26c2

"When you upgrade an enchanted weapon, there is a chance to destroy that enchantment.",

[mchelen]

Ah ok, do you know if it gives the user a notification that this happened?

[vndmtrx]

No, it don't warn for the consequences. Only on tips in the beginning of the level.

[mchelen]

A notification would be nice, since it's only a possibility of occurring.

[jgpacker]

By notification you mean a log entry, right?

[mchelen]

@jgpacker Yup, the text at the bottom of the screen.

[tousdan]

It seems that a message is already there;
"Interaction of different types of magic has negated the enchantment on this weapon!"

https://github.com/watabou/pixel-dungeon/blob/master/src/com/watabou/pixeldungeon/items/weapon/Weapon.java#L139

[mchelen]

Yup, you are right! I must not have seen it, I tested again and sure enough it appeared. Thanks for the correction.