Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Animated and more? [feature request] #18

Open
xcarpentier opened this issue Dec 30, 2019 · 5 comments
Open

Use Animated and more? [feature request] #18

xcarpentier opened this issue Dec 30, 2019 · 5 comments
Labels
enhancement help wanted

Comments

@xcarpentier
Copy link
Collaborator

@xcarpentier xcarpentier commented Dec 30, 2019

Hi Adrian,
A contributor integrates it into GiftedChat and I find it really funny!
But I would like to help out a bit with some PRs:

  1. TypeScript it
  2. Use expo on the root for example (ie. mobile and web on the same level, same structure without example folder but some small script for releases and start:dev, like on GiftedChat?)
  3. Use RN Animated API with native driver by default
  4. Add some other animations type (wait for 1s on the bottom like iOS typing, etc...)

Please let me know your thought about it and a happy new year in advance! 🎉

@watadarkstar
Copy link
Owner

@watadarkstar watadarkstar commented Dec 30, 2019

@xcarpentier Hi, for 1,2 and 4, this sounds good to me 👍 Feel free to help with these PRs. I haven't worked on this library for awhile.

In regards to 3:

  1. Use RN Animated API with native driver by default

The reason I didn't use RN Animated API by default is just because this library can be used with RNW for the web. Some people are using it for that use case. Open for discussion though 😄

@xcarpentier
Copy link
Collaborator Author

@xcarpentier xcarpentier commented Dec 30, 2019

But it's possible to use Animation with RNW... 🙂
See a small example:
https://snack.expo.io/@xcarpentier/animation-example

@watadarkstar
Copy link
Owner

@watadarkstar watadarkstar commented Jan 2, 2020

@xcarpentier In that case, sounds good to me 🙂 let's do it!

@watadarkstar
Copy link
Owner

@watadarkstar watadarkstar commented Jan 4, 2020

@xcarpentier I sent you an invitation to be a collaborator for this library 👬

@Shoukat488

This comment has been minimized.

@watadarkstar watadarkstar added enhancement help wanted labels May 8, 2020
@watadarkstar watadarkstar changed the title Use Animated and more? [not an issue] Use Animated and more? [feature request] May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted
Projects
None yet
Development

No branches or pull requests

3 participants