Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

there is no such prop for hiding and showing the prop [feature request] #22

Closed
dharmendrashah opened this issue May 6, 2020 · 7 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@dharmendrashah
Copy link

i want to add this in my chat application but i didn't see any options for showing and hiding this prop i can do this by our own side but it will be very helpful that it will be the initiated prop option in this modules.

@ghost
Copy link

ghost commented May 6, 2020

Hi @dharmendrashah, this feature will be released soon. What do you say @watadarkstar? I can start working on this right away.

@watadarkstar
Copy link
Owner

@murageden Happy to have you add a prop that lets the user hide the component. Like so:

  • hide (Bool) - When set to true it hides the component

If that's what is being asked?

@watadarkstar watadarkstar changed the title there is no such prop for hiding and showing the prop there is no such prop for hiding and showing the prop [feature request] May 8, 2020
@watadarkstar watadarkstar added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels May 8, 2020
@ghost
Copy link

ghost commented May 8, 2020

Feature request. Sure. I will make a PR as soon as I get on my desk. Thank you @watadarkstar😊

@watadarkstar
Copy link
Owner

@dharmendrashah Do you mean hiding the component? Because you said "hiding this prop" but that doesn't make sense to me.

@ghost
Copy link

ghost commented May 8, 2020

Yeah, obviously he means the whole view/ Component. I understand @dharmendrashah 's limbo. But we want to keep the library as light as possible, that's why we are making just the loader. The functionality for the loader is considered external to the loader. This feature will only be limited to allowing: make the component shown/hidden. It won't include things like timing the showing/hiding states.

@ghost
Copy link

ghost commented May 27, 2020

@watadarkstar, I raised a request for this feature, kindly review and merge. @dharmendrashah this should be fixed after the merge. This issue should be marked as closed now, @watadarkstar.

@watadarkstar
Copy link
Owner

This has been merged in as of PR #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants