Skip to content

Commit

Permalink
fixed image tag's bug
Browse files Browse the repository at this point in the history
  • Loading branch information
Junji Watanabe committed Mar 5, 2013
1 parent cc215ed commit c2626c1
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 8 deletions.
6 changes: 3 additions & 3 deletions src/com/junj/imagerssreader/ItemDetailActivity.java
Expand Up @@ -20,7 +20,7 @@ public void onCreate(Bundle saveInstanceState) {

String title = intent.getStringExtra("TITLE");
String description = intent.getStringExtra("DESCRIPTION");
String imageUrlString = intent.getStringExtra("IMAGEURL");
String imageURL = intent.getStringExtra("IMAGEURL");

mTitle = (TextView) findViewById(R.id.item_detail_title);
mDescription = (TextView) findViewById(R.id.item_detail_descr);
Expand All @@ -30,8 +30,8 @@ public void onCreate(Bundle saveInstanceState) {
mTitle.setText(title);
mDescription.setText(description);

WebImageLoaderTask task = new WebImageLoaderTask(mImage);
task.execute(imageUrlString);
WebImageLoaderTask task = new WebImageLoaderTask(mImage, imageURL);
task.execute(imageURL);
}

}
2 changes: 1 addition & 1 deletion src/com/junj/imagerssreader/RssListAdapter.java
Expand Up @@ -42,7 +42,7 @@ public View getView(int position, View convertView, ViewGroup parent) {

String imageURL = item.getImageURL();
mImage = (ImageView) view.findViewById(R.id.item_image);
WebImageLoaderTask task = new WebImageLoaderTask(mImage);
WebImageLoaderTask task = new WebImageLoaderTask(mImage, imageURL);
task.execute(imageURL);
}

Expand Down
9 changes: 5 additions & 4 deletions src/com/junj/imagerssreader/WebImageLoaderTask.java
Expand Up @@ -12,11 +12,12 @@
public class WebImageLoaderTask extends AsyncTask<String, Void, Bitmap> {
private ImageView mImageView;
private String mUrl;
private String mTag;
private String mImageTag;

public WebImageLoaderTask(ImageView iv) {
public WebImageLoaderTask(ImageView iv, String imageURL) {
mImageView = iv;
mTag = mImageView.getTag().toString();
mImageTag = imageURL;
mImageView.setTag(mImageTag);
}

@Override
Expand Down Expand Up @@ -54,7 +55,7 @@ protected Bitmap doInBackground(String... params) {

@Override
protected void onPostExecute(Bitmap result) {
if (mTag.equals(mImageView.getTag())) {
if (mImageTag.equals(mImageView.getTag())) {
mImageView.setImageBitmap(result);
}
}
Expand Down

0 comments on commit c2626c1

Please sign in to comment.