Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create night mode style #41

Closed
sizovs opened this issue Jun 28, 2018 · 7 comments
Closed

Create night mode style #41

sizovs opened this issue Jun 28, 2018 · 7 comments

Comments

@sizovs
Copy link
Contributor

sizovs commented Jun 28, 2018

No description provided.

@giovannism20
Copy link

I think that's a great idea!

@sizovs
Copy link
Contributor Author

sizovs commented Jul 9, 2018

@giovannism20 look what I found:

https://jenil.github.io/bulmaswatch/darkly/

I think we don't have to create a style for scratch to avoid maintenance overhead, but start with the existing one.

@giovannism20
Copy link

giovannism20 commented Jul 14, 2018

@EduardsI sorry for the delay.

I don't know if it would be a good idea to use this, I think it's black mode is something easy to implement.

@sizovs
Copy link
Contributor Author

sizovs commented Jul 14, 2018

@giovannism20 it will take some time to create a proper Bulma style – it has different colour combinations that needs to be overridden for different components. More importantly, we are not UI professionals end experts in colour. We also can't just override some colors, because it will make Bulma unusable (we have to create fully consistent colour theme in SaaS, as per Bulma recommendations).

We also have to take into account maintenance costs because Bulma, its components, and style guide evolves.

I'd prefer taking existing theme – the one that is created, tested and maintained by UI pro (& community). If we don't like it, we can create our own. Simple first!

@giovannism20
Copy link

@EduardsI sure !

One question and I'm sorry for ignorance, is Bulma already used in the project ?

@sizovs
Copy link
Contributor Author

sizovs commented Jul 14, 2018

@giovannism20 you're right, it's used for component styling

@sizovs
Copy link
Contributor Author

sizovs commented Jul 18, 2018

@sizovs sizovs closed this as completed Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants