Support --stdin-quit functionality #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The core behaviour has been added to the watchexec lib so we update to the latest watchexec and add the flag & hook into the runtime to get the desired behaviour. The switch to a git sha rev for watchexec should be temporary. The other package updates seemed to be required and come from deleting the Cargo.lock entries for once_cell and thiserror to allow them to update and then updating the version of miette to match the one used by watchexec.
|
Yeah, I've got a few things I want to do before I release a cargo watch with the new watchexec engine, but I plan to get to that during the summer (december here) break! So it shouldn't be too long :) |
passcod
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core behaviour has been added to the watchexec lib so we update to the latest watchexec and add the flag & hook into the runtime to get the desired behaviour.
This follows the same pattern as the implementation for the watchexec binary. I hope it is satisfactory.
No rush on this. I realise it involves releasing watchexec and updating this reference which may or may not be something you plan to do soon.
Checklist
watchexecwhen published (rather than a git sha ref)