-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support kill_on_drop(false) on Windows #17
Comments
I would like to suggest as an alternative to both of these that the library handles the setting of these parameters on its own builder. I'm a little bit hesitant because it could lead to some awkward footguns, if, for example, someone sets let mut group = tokio::process::Command::new(path)
.arg("daemon")
.stderr(Stdio::null())
.stdout(Stdio::null())
.group() // converts it to a group builder
.kill_on_drop(false)
.spawn()?; Happy to open a PR, though I realize this is a major breaking change... |
Not necessarily a breaking change, if both group() and group_spawn() are supported. I'm keen, I think that would then make it elegant to support e.g. setting process flags for #15 |
Thanks for the quick reply, I'll get a PR up soon :) |
Hi! I am interested in using this lib to start cross-platform daemons on win / unix. As I understand it, in this case, we should be able to avoid setting the flag here:
https://github.com/watchexec/command-group/blob/main/src/winres.rs#L89
I assume that this is not implemented due to kill_on_drop being private?
Seems to be a similar problem to #15
The text was updated successfully, but these errors were encountered: