Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async bcrypt #3

Open
wolfie82 opened this issue Aug 6, 2014 · 2 comments
Open

Async bcrypt #3

wolfie82 opened this issue Aug 6, 2014 · 2 comments
Labels
bug

Comments

@wolfie82
Copy link

wolfie82 commented Aug 6, 2014

Hi there. Is there any reason as to why you're using the synchronous salt and hash methods from bcrypt?
@duhruh
Copy link
Member

duhruh commented Aug 6, 2014

originally i was unaware that the lifecycle functions took in a callback parameter. I incorrectly assumed they were just synchronous decorator functions. I'll make the change asap! Thanks.

@duhruh duhruh added the bug label Aug 6, 2014
@wolfie82
Copy link
Author

wolfie82 commented Aug 6, 2014

Sounds good 👍

Nice project btw :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wolfie82 @duhruh