Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/search button #66

Merged
merged 21 commits into from
Apr 8, 2022
Merged

Feature/search button #66

merged 21 commits into from
Apr 8, 2022

Conversation

EstebanDalelR
Copy link
Member

@EstebanDalelR EstebanDalelR commented Apr 1, 2022 •
edited

This fixes #53.
image

EstebanDalelR and others added 18 commits March 29, 2022 11:31
@EstebanDalelR
Merge pull request #46 from watermelontools/dev
a8b105d 
Releaseable version
@EstebanDalelR
Merge pull request #63 from watermelontools/dev
875866b 
V0.0.9 release version
@EstebanDalelR
Add button to run the app
ab19e30
@EstebanDalelR
Add code send msg to extension from webview
d019fe2
@EstebanDalelR
Show button is working
a3d32e3
@baristaGeek
Merge pull request #72 from watermelontools/dev
2f3364b 
0.0.12
@EstebanDalelR
Merge pull request #81 from watermelontools/dev
8bfa216 
0.0.12b
@EstebanDalelR
Merge branch 'dev' into feature/searchButton
a152206
@EstebanDalelR
Merge branch 'dev' into feature/searchButton
b8994b4
@EstebanDalelR
Remove unused code
e8d2348
@EstebanDalelR
Fix HTML
20291c8
@EstebanDalelR
Decouple info from painting PRs
d9c7449
@EstebanDalelR
Extract getPRsToPaintPerSHAs locally
90ac89a
@EstebanDalelR
Extract getPRsToPaintPerSHAs
fd646c2
@EstebanDalelR
Add back send message function
46b214e
@EstebanDalelR
Finish button to search
ce01c94
@EstebanDalelR
Add button analytics
4a5fe24
@EstebanDalelR
Make userEmail global
94a315e
@EstebanDalelR EstebanDalelR marked this pull request as ready for review April 7, 2022 16:15
baristaGeek
baristaGeek requested changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@baristaGeek baristaGeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works perfectly. I would do 2 UX/UI things before merging:

  1. Add some margin/padding to the bottom of the button.
  2. Ask a UX/UI designer (or 2) what he thinks about the wording. I suspect something like "Search" would be better. Please discuss.

@EstebanDalelR
Copy link
Member Author 

1. Add some margin/padding to the bottom of the button.

Done. Used margin as padding expands the button

2. Ask a UX/UI designer (or 2) what he thinks about the wording. I suspect something like "Search" would be better. Please discuss.

As per a discussion we had before, I changed it to "Run", maybe search is confusing as it requires an input?

@EstebanDalelR EstebanDalelR merged commit 37639b8 into dev Apr 8, 2022
@EstebanDalelR EstebanDalelR deleted the feature/searchButton branch May 6, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baristaGeek baristaGeek baristaGeek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sidebar needs a button to search
2 participants
@EstebanDalelR @baristaGeek