Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/extract is within plan #69

Merged
merged 21 commits into from
Apr 5, 2022
Merged

Conversation

EstebanDalelR
Copy link
Member

Description

big rewrite to make it all easier to maintain

Type of change

rewrite of current functionality

Copy link
Contributor

@baristaGeek baristaGeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You extracted the endpoint's logic but you're not using the utils getIsWithinPlan file. Should that be happening in this PR?

@EstebanDalelR
Copy link
Member Author

Yes @baristaGeek, it will not be used for the meantime

@baristaGeek
Copy link
Contributor

I love that the PR Titles are clickable now

@EstebanDalelR EstebanDalelR merged commit 09321b1 into dev Apr 5, 2022
@EstebanDalelR EstebanDalelR deleted the chore/extractIsWithinPlan branch May 6, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants