Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/use marked js for markdown #75

Merged
merged 5 commits into from
Apr 6, 2022

Conversation

EstebanDalelR
Copy link
Member

Description

Removed local regex to use MarkedJS
The repo as per #25 comments was suggested.
When used correctly it offsets maintaining to others
https://github.com/markedjs/marked

Type of change

  • Mantainability fix

Copy link
Contributor

@baristaGeek baristaGeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much the same thing but OK.

Can you please change the colors? Both of the characters and the background

@EstebanDalelR
Copy link
Member Author

EstebanDalelR commented Apr 5, 2022

Pretty much the same thing but OK.

Not really, they use a very nice tokenizer and have a little of github flavored markdown parsing.

Can you please change the colors? Both of the characters and the background

Could you be more specific?

@EstebanDalelR
Copy link
Member Author

I've updated the CSS with some of the one used here on github.
anything in a code tag will look more like this
Screen Shot 2022-04-05 at 4 41 27 PM

@EstebanDalelR
Copy link
Member Author

Here are some screenshots in Windows with different themes, both in Insiders and Live versions of vscode
image
image
image

Copy link
Contributor

@baristaGeek baristaGeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for speed. We can worry about the details later.

@EstebanDalelR EstebanDalelR merged commit a3d2a20 into dev Apr 6, 2022
@EstebanDalelR EstebanDalelR deleted the feature/useMarkedJS-for-markdown branch May 6, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants