Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Releasehub? #74

Closed
apenney opened this issue Feb 15, 2022 · 2 comments
Closed

Add Releasehub? #74

apenney opened this issue Feb 15, 2022 · 2 comments

Comments

@apenney
Copy link

apenney commented Feb 15, 2022

Hi,

We have a customer who uses is-ci to tweak their behavior when building, and they've noticed that we're not supported (which is not a surprise, we're a small SaaS company). I had a look at your code and it looks like you just check for env vars, is there any chance you could add a check for:

  • RELEASE_COMMIT_SHA

I know we have kind of a generic name, but I think this should be a pretty unique identifier.

@sibiraj-s
Copy link
Collaborator

Hi @apenney .

Is it possible to add new default environment variables to the runner? May be something like RELEASE_HUB like other vendors do? And Adding CI=true regardless of vendor identification would be helpful.

And RELEASE_COMMIT_SHA will this be available in the runner for all types of triggers?

@sibiraj-s sibiraj-s transferred this issue from watson/is-ci Feb 22, 2022
@sibiraj-s
Copy link
Collaborator

Fixed in v3.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants