Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Shader API causes artifacts #1146

Open
2 tasks done
Revmatek opened this issue Apr 5, 2024 · 4 comments
Open
2 tasks done

Enable Shader API causes artifacts #1146

Revmatek opened this issue Apr 5, 2024 · 4 comments
Labels
Bug MSAA Any issues related to MSAA (Multisample Anti-Aliasing)

Comments

@Revmatek
Copy link

Revmatek commented Apr 5, 2024

Is there an existing issue for this?

  • I have searched the existing issues.

Have you checked the documentation to resolve your problem?

  • I have read the linked documentation and could not resolve my issue.

Current Behavior

When you tick "Enable Shader API" in the main scene, line artifacts can be seen on the horizon underwater through the fog. Sometimes this requires moving the camera around a bit.

Expected Behavior

Enabling the Shader API should not create artifacts.

Steps To Reproduce

  1. Open Main.unity
  2. Play
  3. Go underwater
  4. Turn on the shader api
  5. Observer artifacts on the horizon (sometimes you have to move the camera around to see them)
image

Unity Version

2021.3.26

Crest Version

4.19

Render Pipeline

Built-In

Editor or Standalone

Editor (Edit Mode), Editor (Play Mode), Standalone

Environment

No response

Anything else?

This issue may be related to: #1145

@daleeidd
Copy link
Collaborator

daleeidd commented Apr 5, 2024

Looks like this is affected by MSAA. Do you have MSAA enabled?

@Revmatek
Copy link
Author

Revmatek commented Apr 5, 2024

Looks like this is affected by MSAA. Do you have MSAA enabled?

I am not using MSAA currently. However enabling it and enabling the shader API also does not trigger artifacts in my environment. I only saw that in the main scene at the last minute so I have not really investigated.

@daleeidd daleeidd added the MSAA Any issues related to MSAA (Multisample Anti-Aliasing) label Apr 6, 2024
@daleeidd
Copy link
Collaborator

daleeidd commented Apr 7, 2024

MSAA is active for the Main scene and disabling it removes it. The scene view does not support MSAA so will not exhibit the issue. And MSAA can be difficult to enable sometimes.

@Revmatek
Copy link
Author

Revmatek commented Apr 7, 2024

MSAA is active for the Main scene and disabling it removes it. The scene view does not support MSAA so will not exhibit the issue. And MSAA can be difficult to enable sometimes.

That sounds accurate to me. I am using separate anti-aliasing so it is a non issue. MSAA causes problems with other things that are not related to the ocean shader as well, though I don't remember specific examples. To confirm though, it does happen at runtime, and the artifact line will move as you adjust Depth Fog Density Factor, but only with Enable Shader API on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug MSAA Any issues related to MSAA (Multisample Anti-Aliasing)
Projects
None yet
Development

No branches or pull requests

2 participants