-
-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Planar Reflections issue with non-standard shaders using transparency #1147
Comments
Does changing the Clear Flags to Skybox solve it? |
Changing the Clear Flags does not seem to have an effect. The clear flags for the image above is with Skybox. |
Is that on the OceanPlanarReflections script? Otherwise can you remove the
|
That image looks like OceanPlanarReflections > Clear Flags is not set to Skybox. Unless your skybox does not write alpha which would be strange. Try testing with Unity's procedural skybox. |
Can you provide a screenshot of the OceanPlanarReflections component? |
No worries. Does it work correctly if you remove the reflection alpha modification? |
Perfect. That could be a combination of fresnel and colours blending. I'll make Skybox the default as prefer to have things work over an optimisation. I'll document this in the tooltip and somewhere in the documentation too. |
Fixed in 4.20. |
Is there an existing issue for this?
Have you checked the documentation to resolve your problem?
Current Behavior
Planar reflections texture does not show custom shaders / transparency. It may be custom shaders in general if I recall. I think it works for most standard shaders.
Note: that the palm leaves are not visible in the reflection.
![image](https://private-user-images.githubusercontent.com/114962753/320152765-fb36bc0f-11a2-4f95-9f11-60facc2cbb18.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkxNDk4MTMsIm5iZiI6MTcxOTE0OTUxMywicGF0aCI6Ii8xMTQ5NjI3NTMvMzIwMTUyNzY1LWZiMzZiYzBmLTExYTItNGY5NS05ZjExLTYwZmFjYzJjYmIxOC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNjIzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDYyM1QxMzMxNTNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lY2UyOGE4ODI3Y2YxZjIxODQyOWMzNGI3NjM5OGEzYTg5NjE3MTgwNzU4YTFhOWM2MzdjODA5YjAwZjNiYTNlJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.0Tk0oX96bw16yqzxRNa2hbT3A-CfE872hvC4oLfMhYI)
My primary concern for this is the tree leaves not showing up. This example has hidden shaders on the tree which I cannot redo easily. The example light blue cube is something I can modify to add support if that is possible.
Expected Behavior
There should be some sort of way to add support for transparency in custom shaders (seems to work fine for Standard Shaders with transparency, which may exclude all forms of tree shader)
Steps To Reproduce
Unity Version
2021.3.26
Crest Version
4.19
Render Pipeline
Built-In
Editor or Standalone
Editor (Edit Mode), Editor (Play Mode), Standalone
Environment
No response
Anything else?
Filling this out here while investigating other issues, this was in my backlog, not terribly important but probably a bug somewhere. I investigated it a one point and ended up in a shader somewhere that was applying transparency to the planar reflection texture or something... I don't recall the specifics. I am not sure if there is some workaround to this I am unaware of, something I need to add in the shaders perhaps.
The text was updated successfully, but these errors were encountered: