Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible rendering problems with High Sierra #395

Closed
jason0x43 opened this issue Sep 26, 2017 · 31 comments
Closed

Possible rendering problems with High Sierra #395

jason0x43 opened this issue Sep 26, 2017 · 31 comments

Comments

@jason0x43
Copy link

  • Which version of Wavebox are you using? [e.g. 3.0.0]

3.3.3beta

  • Which Operating System are you using? [e.g. Windows 10, Mac OSX 10, Ubuntu 14.04]

Mac OSX High Sierra

Since updating to High Sierra yesterday I've been seeing some weird rendering issues with Wavebox. Sometimes icons for account services (like Drive and Calendar for a Google Inbox account) won't render in the left bar, although the main account icons do. Also, content in the main content area isn't rendered. Like, for an Inbox account only the "+" button and a few headings will be rendered initially, and the rest of the content area will be empty space. Moving the mouse over the content area will cause the content under the mouse to redraw (so moving the mouse around in the content area will eventually cause everything to be drawn properly).

This could be unrelated to my High Sierra upgrade (and I'm not sure what in HS would cause Electron rendering issue), but it seems pretty coincidental.

@Thomas101
Copy link
Member

Hi, thanks for reporting. It would be great to have some more info so we can try to reproduce it...

  1. Does this happen everytime or is it sporadic?
  2. Would you be able to send a screenshot our way
  3. Do you know the year and model of your mac

There are a couple of settings that might also help. If you open Settings and then the Advanced tab, try enabling Ignore GPU Blacklist, restarting and seeing if that makes a difference. If it doesn't, feel free to turn this off again and try enabling Disable hardware acceleration.

@jason0x43
Copy link
Author

At the time I was reporting, it was happing very frequently. Like, I'd start Wavebox, everything would look normal, then at some point I'd look back and UI elements would have disappeared. However, the issue seems to have calmed down for the moment. Possibly it was just some transient GPU-related issue from to the upgrade. I'll add more details if it comes up again.

@Thomas101
Copy link
Member

Thanks for the update. I'll close this off for now, but if you start seeing it again let us know and we'll look into again

@jason0x43
Copy link
Author

I've continued to see this behavior occasionally. I attached a few screenshots showing the issue (the pixelated content is not part of the issue). In the first, Wavebox has suddenly become mostly empty. I haven't been able to determine any particular trigger for this. Sometimes it happens when Wavebox first opens, sometimes just randomly (presumably after something prompted a redraw). In any case, in the first screenshot the service icons are missing on the left (Calendar and Hangouts under the top account, and Calendar and Drive under the second account), and most of the Inbox content is empty. The remaining shots were taken after moving the mouse around, which causes page elements to render. Moving the mouse over the service icons will cause their tooltips to show, but won't cause the icons to render. However, clicking the service icons will cause them to render.

Refreshing the account (with cmd-r) will cause Inbox to fully render, and refreshing the entire UI (with cmd-shift-r) will cause the service icons to render.

screen shot 2017-10-02 at 20 02 50
screen shot 2017-10-02 at 20 02 55
screen shot 2017-10-02 at 20 03 12
screen shot 2017-10-02 at 20 03 22

@Thomas101
Copy link
Member

Drats, was hoping it was just something sporadic! I haven't seen anything reported on electron issues as of yet, so I'm wondering if this is something that Wavebox is doing that a lot of other apps are not.

If you click the Apple icon in the top-right of your screen and go to About this mac, would you be able to send a screenshot of the Overview tab? Maybe we can try to get a machine to reproduce the issue here.

@Thomas101 Thomas101 reopened this Oct 3, 2017
@jason0x43
Copy link
Author

Yeah, so was I. :(

I don't run any other Electron apps on a regular basis, so I can't say much there. I've only seen the issue with Wavebox, both in the main window and in external windows opened by Wavebox.

screen shot 2017-10-03 at 08 10 04

@geoffoliver
Copy link

I'm experiencing the same issue with similar hardware.
screen shot 2017-10-03 at 2 07 26 pm

@Thomas101 Thomas101 added bug and removed more-info labels Oct 4, 2017
@Thomas101 Thomas101 added this to the Version 3.5 milestone Oct 4, 2017
@Thomas101
Copy link
Member

It looks could be related to discrete graphics rendering then. Just at a guess.

We've got a macbook pro that I think has a card in here, so I'll try to update that one and see if I can reproduce.

There's also a new version of electron available which uses a newer version of chromium. We've yet to update to this as it's still hot off the press, but I'll be looking to do that in the next week or so, I'll pass a build your way once we've done that to see if resolves the issue.

@plan8studios have you tried enabling Disable hardware acceleration under advanced settings?

Another thing to try might be to show the titlebar. A few people upstream have reported some graphical problems with the frameless window. If you open settings in Wavebox in the User Interface section there's a Show titlebar option, try enabling this

@jason0x43
Copy link
Author

Ah, I forgot about disabling hardware acceleration. I'll give that a shot.

Also, regarding the title bar, I've also seen the issue in secondary Wavebox browser windows that do have title bars, if that's relevant.

@geoffoliver
Copy link

I've disabled hardware acceleration. Fingers crossed! :-)

@Kachilero
Copy link

I've also been experiencing some rendering issues after updating to High Sierra, chief among them is that the app would go blank from time to time, but that seems to have stopped.
I'm also experiencing a probably unrelated issue where when the app is in full screen mode, the icons for minimizing disappear.

@jason0x43
Copy link
Author

Disabling hardware acceleration seems to have done the trick. I haven't noticed any flashing, missing UI elements, or other redrawing issues.

Also, ironically, Inbox seems to work more smoothly. When hardware acceleration was enabled, it seemed like Inbox was sometimes slow to respond, or took multiple clicks, or was in some difficult-to-define way unresponsive. Possibly this is related to whatever redrawing issue caused elements to no appear, or sometimes caused flashing in the window. It seems to behave better now. That could just be me, though.

@geoffoliver
Copy link

So far, so good! One day in with hardware acceleration disabled and no weird UI glitches 👍

@Thomas101
Copy link
Member

Good to hear that's working for now! I'll be getting a new beta out early next week which has a newer version of Chromium, I'm hoping this will fix the compatibility issues without needing to disable hw acceleration

@nlenkowski
Copy link

I've been seeing a similar issue after upgrading to High Sierra, but not just with Wavebox. Both Chrome itself and a few other Electron based apps I use are having occasional rendering glitches. I'm on an older Macbook Pro mid-2012 w/ a discrete graphics card (Nvidia 650M). Perhaps there is an upstream issue with Chromium or Electron?

I've tried resetting the PRAM and SMC and clearing all MacOS caches, to no effect. I'll try turning off hardware acceleration, but that's a temporary fix.

@raptor235
Copy link

Seeing same issues, Atom & Chrome have had artifacts all week long...

Chipset Model: NVIDIA GeForce GT 750M

@jason0x43
Copy link
Author

Hardware acceleration definitely seems to be the issue. I haven't seen this problem come up at all since disabling hardware acceleration a couple of weeks ago.

@chris-X73
Copy link

I'm experiencing the same problem with other apps like Trello and Google GSuite as well. Parts of browser window are not rendered correctly or totally missing, browser content is flickering etc. - so I don't think the problem is related to Wavebox but more to High Sierra in combination with Chrome.

@chris-X73
Copy link

Disabling hardware acceleration in Chrome worked for me as well to quickfix the problem. 👍

@nlenkowski
Copy link

For those not aware, this looks to be an upstream issue with Chromium that affects both Chrome and Electron apps for macOS High Sierra users with certain discrete graphics cards. A Chromium bug report has been filed here, https://bugs.chromium.org/p/chromium/issues/detail?id=773705

@raptor235
Copy link

I've submitted a bug report to apple.. problem id 35284875 not sure if they'll ever get to it... if they don't I guess a downgrade back to sierra will be required... I can't put up with this much longer.

@Thomas101 Thomas101 removed this from the Version 3.5 milestone Nov 1, 2017
@Thomas101 Thomas101 added this to the Version 3.6 milestone Nov 1, 2017
@Thomas101
Copy link
Member

@raptor235 there's some chatter on the Chromium issue tracker about this being a problem with the GPU driver. I think the Chromium team are looking to disable certain gpu features on certain machines until Apple patch the driver. Once a fix makes it out into a Chromium release, we'll be updating Wavebox too

@raptor235
Copy link

Yeah I've tried disabling some of those features in chrome flags which kills the performance... so not sure how much of a fix that's going to be... we really need to make a stink of this to apple because it seems they're going to be the only ones to be able to fix this. Since it's older hardware I don't know if it's going to be at any high priority... you know they're working on implementing the next set of emoji into osx... sigh..

Latest release doesn't mention any issues about this.... I don't know how this stuff gets past as they spend a ton of money on tech.

@felipedrumond
Copy link

I'm having exactly the same issues mentioned in this thread, but only in Chrome based apps, such as Chrome and Postman.

@Thomas101
Copy link
Member

Some users on electron/electron#10736 (comment) have reported that downloading the beta drivers from nvidia has helped them with graphics issue. We haven't been able to confirm yet, but if anyone's looking at updating anyway it would be great to know how it works for them.

The drivers can be downloaded from http://www.nvidia.com/download/driverResults.aspx/126538/en-us

@felipedrumond
Copy link

@Thomas101 I'm giving it a chance. Let's see what happens.

@felipedrumond
Copy link

@Thomas101 After installing those drivers, I haven't seen any renderisation issues.

@Thomas101
Copy link
Member

@felipedrumond That's great news! There's some patches gone into electron which are supposed to help with this too - these will be shipping in the 3.5.2 beta shortly

@felipedrumond
Copy link

@Thomas101 Confirming... I had no renderisation issues after updating the drivers! Thank you!

@Thomas101
Copy link
Member

Hi, we’ve just released a fix for this to the beta channel of Wavebox in version 3.5.2. If you want to give it a try there are some instructions on how to use the beta channel here. Thanks

@Thomas101
Copy link
Member

Hi, this has just been released in the latest version of Wavebox. You can get the update by using the Application/File menu and clicking Check for Update or by downloading the latest version from our download page. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants