Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

☯️ #4

Open
drom opened this issue Nov 2, 2018 · 6 comments
Open

☯️ #4

drom opened this issue Nov 2, 2018 · 6 comments

Comments

@drom
Copy link
Member

drom commented Nov 2, 2018

☯️ Light on Dark vs. Dark on Light ☯️

Most of the interactive waveform viewers use light lines over dark background.
Datasheets usually prefer black (dark) lines and text on the white (paper) background.
Do we need to support both modes?
Can it be skinnable?

@drom drom mentioned this issue Nov 2, 2018
@Paebbels
Copy link

Paebbels commented Nov 2, 2018

Working with waveforms on dark background helps to relax your eyes. While eyes are more stressed to work on light backgrounds. Another help for eyes is the shadow below high signals.

@nturley
Copy link

nturley commented Nov 3, 2018

For the interactive viewer I prefer dark background. If I export/screenshot something for documentation, I'd want it to be light background so it could be potentially printable.

@DrSensor
Copy link

DrSensor commented Nov 3, 2018

Agree with skinnable parts, especially if it can be skinned using CSS. The question is what kind of CSS? inline style or global (internal/external)?

@drom
Copy link
Member Author

drom commented Nov 3, 2018

Agree with skinnable parts, especially if it can be skinned using CSS. The question is what kind of CSS? inline style or global (internal/external)?

DOM elements (HTML, SVG) can be stylized with CSS, I am not sure about Canvas.
Also if we need saving standalone SVG files they have to include all CSS

@DrSensor
Copy link

DrSensor commented Nov 3, 2018

Then inline style could be the appropriate solution. The downside is the theme author can't use pseudo-selectors like :hover, :focus, etc. For Canvas, how about draw the SVGElement into Canvas?

@drom
Copy link
Member Author

drom commented Nov 3, 2018

Related : https://twitter.com/ico_TC/status/1058673928850292736

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants