Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting for adding a proxy level point tag in wavefront.conf #245

Closed
shahdhruvin opened this issue Feb 2, 2018 · 3 comments
Closed

Setting for adding a proxy level point tag in wavefront.conf #245

shahdhruvin opened this issue Feb 2, 2018 · 3 comments
Assignees

Comments

@shahdhruvin
Copy link

I am looking at the use-case where I will have to repeat the point tag addition rule for all the ports (3 for now we have) in the preprocessor_rules.html file.

For me this is a proxy level rule, not an collector agent level rule.
Hence I started looking into wavefront.conf, tried out few things. and finally came to know that I need to actually apply this point tag rule in preprocessor_rules.

It is instinctive for this proxy level rule to be in wavefront.conf

Adam agreed to this logic over slack channel.
Adam Johnson [3:08 PM]
I agree, for a global thing like that wavefront.conf would be good, but I’m not sure the main conf file has any point tag controls.

And then as per Conor's suggestion - opening this PR

@shahdhruvin
Copy link
Author

Looks like this is a lot of plumbing work required to apple a point tag at a proxy level.
In preprocessor - Apply identical rule per port (3 times)
And then apply logsIngestion changes too, may be again repeat tags there per counter, histogram or gauge?

@panghy
Copy link
Contributor

panghy commented Jun 3, 2018

@basilisk487 can you respond to the ticket?

@akodali18
Copy link
Contributor

Closing this issue. Fixed with #503

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants