Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transactions redesign #128

Merged
merged 51 commits into from Oct 29, 2021
Merged

Transactions redesign #128

merged 51 commits into from Oct 29, 2021

Conversation

smelnikov
Copy link
Contributor

No description provided.

smelnikov and others added 26 commits October 16, 2021 21:11
@smelnikov
Prepare transaction JSON
8c73306
@smelnikov
KEEP-91 Fixes transformation of BigNumber (#125)
911bd95
@smelnikov
Refactor FinalTx components
5097210
@smelnikov
Transaction tabs
913029d
@smelnikov
TransactionWallet replacement to top
10e8dd0
@smelnikov
Issue Card
bbcb006
@smelnikov
Transfer Card
cc494ec
@smelnikov
FinalTransaction layout
9dca323
@smelnikov
FinalTransaction styles
d33fc87
@smelnikov
ReissueCard
085c75c
@smelnikov
BurnCard
ca419a9
@smelnikov
LeaseCard
33164e9
@smelnikov
CancelLeaseCard
58b99af
@smelnikov
AliasCard
6a14faa
@smelnikov
MasterTransferCard
a8c717b
@smelnikov
Fix object deep cloning
cc15736
@smelnikov
SetScriptCard
0b68dcb
@smelnikov
DataCard
4c003ed
@smelnikov
SponsorshipCard
836256b
@smelnikov
AssetScriptCard
1f20b4c
@smelnikov
ScriptInvocationCard and Plate component
bf4d43c
@smelnikov
Using <Trans> without fallback children
7cc1832
@smelnikov
TransactionWallet with copying
b0ce416
@smelnikov
Extracted common components to BaseTransaction module
7375f69
@smelnikov
Removed duplicate Info components
3a8ea63
@smelnikov
Removed unused info attribute
001c1e0
@smelnikov smelnikov force-pushed the KEEP-92/transactions_redesign branch from 83f6665 to 001c1e0 Compare October 23, 2021 19:29
@smelnikov smelnikov force-pushed the KEEP-92/transactions_redesign branch from b4424f3 to 1bb73cf Compare October 25, 2021 16:51
@smelnikov smelnikov force-pushed the KEEP-92/transactions_redesign branch from 1bb73cf to 4afb4c5 Compare October 25, 2021 17:16
@smelnikov smelnikov marked this pull request as ready for review October 25, 2021 17:36
faergeek
faergeek approved these changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@faergeek faergeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments here and there. That's just a matter of style, nothing critical. In general, great job, nice clean up and deduplication 👍

src/controllers/MessageController.js Outdated Show resolved Hide resolved
src/ui/components/pages/MessagesList.tsx Outdated Show resolved Hide resolved
src/ui/components/transactions/Alias/Alias.tsx Outdated Show resolved Hide resolved
src/ui/components/transactions/Alias/AliasFinal.tsx Outdated Show resolved Hide resolved
src/ui/components/transactions/AssetScript/AssetScriptFinal.tsx Outdated Show resolved Hide resolved
src/ui/components/transactions/Auth/AuthFinal.tsx Outdated Show resolved Hide resolved
src/ui/components/transactions/BaseTransaction/TxInfo.tsx Outdated Show resolved Hide resolved
src/ui/components/ui/Tabs/Tabs.tsx Outdated Show resolved Hide resolved
src/ui/components/ui/Tabs/tabs.styl Outdated Show resolved Hide resolved
src/ui/utils/converters.ts Outdated Show resolved Hide resolved
@smelnikov smelnikov mentioned this pull request Oct 27, 2021
Merged
@smelnikov smelnikov force-pushed the KEEP-92/transactions_redesign branch from 48e3d25 to 7265676 Compare October 28, 2021 22:45
@smelnikov smelnikov merged commit 177b3a6 into master Oct 29, 2021
@smelnikov smelnikov deleted the KEEP-92/transactions_redesign branch October 29, 2021 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faergeek faergeek faergeek approved these changes

@msmolyakov msmolyakov Awaiting requested review from msmolyakov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smelnikov @faergeek