Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outline offset doesn't support string values #127

Closed
2 tasks done
richbachman opened this issue Mar 23, 2023 · 0 comments · Fixed by #128
Closed
2 tasks done

Outline offset doesn't support string values #127

richbachman opened this issue Mar 23, 2023 · 0 comments · Fixed by #128
Labels
bug Something isn't working

Comments

@richbachman
Copy link
Contributor

Description

While working with rainbow-sprinkles, I noticed outlineOffset is set to a number. That doesn't seem to render in browsers. It looks like the offset prop should take a standard length value. See the MDN docs here: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-offset

Expected Behaviour

outlineOffset renders the properly set offset.

Actual Behaviour

outlineOffset value is ignored.

Affected Version

0.16.0

Steps to Reproduce

  1. Add outlineOffset: true to the dynamic properties.
  2. Try to use a px or rem value within Box.

Checklist

@roginfarrer roginfarrer added the bug Something isn't working label Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants