Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does compute_range_image_polar and compute_range_image_cartesian return vehicle frame? #20

Closed
skaae opened this issue Aug 30, 2019 · 1 comment

Comments

@skaae
Copy link

skaae commented Aug 30, 2019

Does compute_range_image_polar and compute_range_image_cartesian return range images in vehicle frame?

I assume it does because in the tutorial extract_point_cloud_from_range_image is called with an extrinsic transform that is from lidar frame to vehicle frame:

extrinsic = np.reshape(np.array(c.extrinsic.transform), [4, 4])
range_image_tensor = tf.reshape(
tf.convert_to_tensor(range_image.data), range_image.shape.dims)
pixel_pose_local = None
frame_pose_local = None
if c.name == dataset_pb2.LaserName.TOP:
pixel_pose_local = range_image_top_pose_tensor
pixel_pose_local = tf.expand_dims(pixel_pose_local, axis=0)
frame_pose_local = tf.expand_dims(frame_pose, axis=0)
range_image_mask = range_image_tensor[..., 0] > 0
range_image_cartesian = range_image_utils.extract_point_cloud_from_range_image(
tf.expand_dims(range_image_tensor[..., 0], axis=0),
tf.expand_dims(extrinsic, axis=0),
tf.expand_dims(tf.convert_to_tensor(beam_inclinations), axis=0),
pixel_pose=pixel_pose_local,
frame_pose=frame_pose_local)

In the docs for compute_range_image_cartesian it says that it expect the range image in polar coordinates to be in sensor frame?

@peisun1115
Copy link
Contributor

compute_range_image_polar return coordinates in sensor frame.
compute_range_image_cartesian returns coordinates in vehicle frame.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants