Fixed crash when removing the first node from a LinkedList with a cou… #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @malmazuke, thanks for sending along this PR. Have you also had a chance to check this issue / fix with the Swift-3.0 branch? https://github.com/waynewbishop/SwiftStructures/tree/swift-3.0 |
|
Hi @waynewbishop, not yet. I can't get the swift-3.0 branch compiling unfortunately. I'm using Xcode 8 beta 6. |
|
Hi @malmazuke, sounds good. I just updated the code project to support Xcode 8.0 beta 6. If you would like to resubmit your PR that would be great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nt of 1
This crash can be reproduced by creating a new LinkedList, adding a value, and then immediately removing it. The crash occurs because
head.nextis nil.Additionally, I moved the
index == 0check before the initialization ofcurrent, as it doesn't need to use it.I can change the ternary operator to an if-statement if you think it's more readable.