Fixed QuickSort algorithm. Added tests for QuickSort #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've fixed implementation of QuickSort. New implementation ensures O(n log n) complexity for case when array contains duplicates. Old realisation provided quadratic time for such cases. I've added tests to check QuickSort with different cases - with duplicates, with different array sized, already sorted array.
|
Hi @n0an, thanks for sending this pull request! I'm considering providing a book update later this month these updates to QuickSort would be great to add. Thanks for sharing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed implementation of QuickSort. New implementation ensures O(n log n) complexity for case when array contains duplicates.
Old realisation provided quadratic time for such cases.
I've added tests to check QuickSort with different cases - with duplicates, with different array sized, already sorted array.