Code metrics improvements / code optimizations / production (readability/coupling/complexity) #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity/coupling/complexity) LinkedList<T> optimizations: -added counter variable -added overflow/underflow exceptions -moved counter to read-only property -moved code to function nodeAtIndex function -changed variables to optionals for readability -removed overcompilcated code blocks -removed Enumerable constraint for T -removed print LLNode<T> optimizations: -added default init and parametrized init to LLNode<T> Tests modifications: -added try! code block to bypass exception handling
|
Wanted to pull into waynewbishop/develop trunk - missed that little button in GitHub, then. |
|
pull request #66 is opened |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LinkedList optimizations:
-added counter variable
-added overflow/underflow exceptions
-moved counter to read-only property
-moved code to function nodeAtIndex function
-changed variables to optionals for readability
-removed overcompilcated code blocks
-removed Enumerable constraint for T
-removed print
LLNode optimizations:
-added default init and parametrized init to LLNode
Tests modifications:
-added try! code block to bypass exception handling