Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android Call with dialog empty #33

Closed
geraintwhite opened this issue Mar 29, 2019 · 1 comment
Closed

Android Call with dialog empty #33

geraintwhite opened this issue Mar 29, 2019 · 1 comment

Comments

@geraintwhite
Copy link
Contributor

On some Samsung devices there is a problem when a default calling account has not been chosen. When a call is made from the Phone app, the call with dialog should show the SIM and the CallKeep app but it is blank.

This has been reproduced on Samsung S9 with Android 9 (but was fixed in a security patch from Samsung) and Samsung Note 9 with Android 9 (no security patch available yet), but works correctly on Samsung S8 with Android 9.

I know this is not a problem with the library and is a Samsung OS issue, but a possible workaround could be checking if a default is set (with telecomManager.getDefaultOutgoingPhoneAccount("tel")) and sending the user to the calling accounts settings (TelecomManager.ACTION_CHANGE_PHONE_ACCOUNTS) for them to set a default.

Screenshot 2019-03-29 at 09 41 03

manuquentin added a commit that referenced this issue Apr 2, 2019
Add checkDefault method for addressing #33
@geraintwhite
Copy link
Contributor Author

Fixed in 7d73060

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant