Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Winston logs for the reporting module #1622

Closed
4 tasks done
jesusgn90 opened this issue Jul 22, 2019 · 1 comment
Closed
4 tasks done

Add Winston logs for the reporting module #1622

jesusgn90 opened this issue Jul 22, 2019 · 1 comment
Assignees
Labels
back-end Thins related to the server side type/enhancement Enhancement issue
Milestone

Comments

@jesusgn90
Copy link
Contributor

jesusgn90 commented Jul 22, 2019

Hi team,

The module reporting has no logs. It's frustrating when a report fails and we can't see more than one or two requests with no useful information about the fault.

Tasks:

  • Add the module (import { log } from '../logger';)
  • Add INFO logs for all methods (at least one message just for follow the trace)
  • Add DEBUG logs for all methods, where we can see details such as the URLs, filters, API ID, and any other relevant information for a troubleshooting session.
  • Add ERROR logs for all the catch and all parts of the code where we are handling any kind of error.
@jesusgn90 jesusgn90 added type/enhancement Enhancement issue back-end Thins related to the server side logger labels Jul 22, 2019
@jesusgn90 jesusgn90 self-assigned this Jul 22, 2019
@jesusgn90 jesusgn90 added this to To do in Wazuh 3.10.0 via automation Jul 22, 2019
@jesusgn90 jesusgn90 removed this from To do in Wazuh 3.10.0 Aug 22, 2019
@jesusgn90 jesusgn90 added this to To do in Wazuh 3.11.0 via automation Aug 22, 2019
@jesusgn90 jesusgn90 added this to the 36th week sprint milestone Sep 3, 2019
@jesusgn90 jesusgn90 moved this from To do to In progress in Wazuh 3.11.0 Sep 4, 2019
@jesusgn90 jesusgn90 moved this from In progress to Needs review in Wazuh 3.11.0 Sep 4, 2019
@jesusgn90
Copy link
Contributor Author

Branch: https://github.com/wazuh/wazuh-kibana-app/tree/reporting-logger-1622

Here 73b3ccb we've added logs for INFO, DEBUG and ERROR level. Now the reporting module shows valuable information and errors when "debug" mode is disabled and when "debug" mode is enabled we can see the full trace in all functions.

@adri9valle adri9valle moved this from Needs review to Done in Wazuh 3.11.0 Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end Thins related to the server side type/enhancement Enhancement issue
Projects
No open projects
Wazuh 3.11.0
  
Done
Development

No branches or pull requests

2 participants