Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.0.4-7.10.0] Fix mitre framework tab crash #2821

Merged
merged 1 commit into from
Jan 26, 2021
Merged

[4.0.4-7.10.0] Fix mitre framework tab crash #2821

merged 1 commit into from
Jan 26, 2021

Conversation

frankeros
Copy link
Contributor

@frankeros frankeros commented Jan 22, 2021 •
edited
Loading

Hi team, this resolves

  • Mitre module crash when tab Framework is opened in Kibana prod

The same fix solve the same problem in PCI DSS , HIPPA , GDPR , TSC , NIST 800-53

Closes #2808 #2841

@frankeros frankeros self-assigned this Jan 22, 2021
@frankeros frankeros changed the base branch from master to 4.0-7.10 January 22, 2021 20:09
@frankeros frankeros added this to the Sprint 123 - WUI milestone Jan 22, 2021
gabiwassan
gabiwassan approved these changes Jan 22, 2021
View reviewed changes
Copy link
Contributor

@gabiwassan gabiwassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@frankeros frankeros linked an issue Jan 26, 2021 that may be closed by this pull request
PCI DSS dashboard stops working after visiting Controls section #2841
Closed
@Desvelao
Copy link
Member

I tested the PR with Kibana 7.10.0 in production without security and it is working.
image
image
image
image
image
image

Desvelao
Desvelao approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Desvelao Desvelao merged commit 8eeffda into 4.0-7.10 Jan 26, 2021
@Desvelao Desvelao deleted the bugfix/2808-mitre-framework-crash branch January 26, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabiwassan gabiwassan gabiwassan approved these changes

@Desvelao Desvelao Desvelao approved these changes

Assignees

@frankeros frankeros

Labels
None yet
Projects
None yet
Milestone
Sprint 123 - WUI
3 participants
@frankeros @Desvelao @gabiwassan